Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): handle item type combobox with nested selections #1726

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

jordantsanz
Copy link
Contributor

@jordantsanz jordantsanz commented Nov 8, 2024

  1. Description:
  • Adds selectionMode property to combobox so that multiple selectionMode does not automatically select parents by default
  • Updates the applyWellKnownItemPredicates function to handle family types as well
  1. Instructions for testing:

  2. Closes Issues: # (if appropriate)

  3. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  4. used semantic commit messages

  5. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  6. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

Copy link

There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label.

@github-actions github-actions bot added the Stale Stale issue - update or it will be closed label Nov 12, 2024
@jordantsanz jordantsanz added Draft Draft PR or Issue (don't mark stale) and removed Stale Stale issue - update or it will be closed labels Nov 15, 2024
@jordantsanz jordantsanz changed the title fix(): update iscomboboxitemselected function to pay attention to selection mode feat(): handle item type combobox with nested selections Nov 26, 2024
Copy link
Contributor

@vivzhang vivzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@abp6318 abp6318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very slay! I tested this with the opendata-ui PR you have as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Draft Draft PR or Issue (don't mark stale)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants